Latest LBP design implementation for metri testing #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1.7.0
…erFrom to factory
roleengineer
changed the title
|
Implemented the latest LBP design. Next step basic test coverage. |
benjaminbollen
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
LGTM, I would perhaps request the following points (this can in parallel or before test deployment)
- I think we should explicitly check that the avatar sending their 48CRC
hub.isHumanto exclude groups to partake - Factory currently has
backerOf, but can we also store the reverse mappingbacker -> CirclesBackingand a func in Factory that checks in CirclesBacking.sol whether the callbackcreateLBPhas been completed (and the 1yr lock is still active) (effectivelybalancerPoolTokensUnlockTimestamp > 0 and balancerPoolTokensUnlockTimestamp < block.timestamp
this way I can in the supergroup call on the CirclesBackingFactory to ask if the address I want to trust has an actively backed and locked LBP present
amazing work 🚀
|
I've resolved review comments. Starting tests. |
|
Looks great to me ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the PoC to get Factory template.
Next step would be to implement actual factory logic.